buffer: remove lines setting indexes to integer value

PR-URL: #52588 Refs: #52585 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs · May 6, 2024 · bf8afe7 · bf8afe7
1 parent b1b0233
commit bf8afe7
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 2 deletions.
diff --git a/lib/internal/blob.js b/lib/internal/blob.js
@@ -243,14 +243,12 @@ class Blob {
     } else {
       start = MathMin(start, this[kLength]);
     }
-    start |= 0;
 
     if (end < 0) {
       end = MathMax(this[kLength] + end, 0);
     } else {
       end = MathMin(end, this[kLength]);
     }
-    end |= 0;
 
     contentType = `${contentType}`;
     if (RegExpPrototypeExec(disallowedTypeCharacters, contentType) !== null) {

diff --git a/test/pummel/test-blob-slice-with-large-size.js b/test/pummel/test-blob-slice-with-large-size.js
@@ -0,0 +1,21 @@
+'use strict';
+const common = require('../common');
+
+// Buffer with size > INT32_MAX
+common.skipIf32Bits();
+
+const assert = require('assert');
+
+const size = 2 ** 31;
+
+try {
+  const buf = Buffer.allocUnsafe(size);
+  const blob = new Blob([buf]);
+  const slicedBlob = blob.slice(size - 1, size);
+  assert.strictEqual(slicedBlob.size, 1);
+} catch (e) {
+  if (e.code !== 'ERR_MEMORY_ALLOCATION_FAILED') {
+    throw e;
+  }
+  common.skip('insufficient space for Buffer.allocUnsafe');
+}