tty: fix TypeError when stream is closed

Fixes: #41330 PR-URL: #43803 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
nodejs · Oct 11, 2022 · be863b7 · be863b7
1 parent f0d841f
commit be863b7
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/tty.js b/lib/tty.js
@@ -73,7 +73,7 @@ ObjectSetPrototypeOf(ReadStream, net.Socket);
 
 ReadStream.prototype.setRawMode = function(flag) {
   flag = !!flag;
-  const err = this._handle.setRawMode(flag);
+  const err = this._handle?.setRawMode(flag);
   if (err) {
     this.emit('error', errors.errnoException(err, 'setRawMode'));
     return this;

diff --git a/test/parallel/test-repl-stdin-push-null.js b/test/parallel/test-repl-stdin-push-null.js
@@ -0,0 +1,9 @@
+'use strict';
+const common = require('../common');
+
+if (!process.stdin.isTTY) {
+  common.skip('does not apply on non-TTY stdin');
+}
+
+process.stdin.destroy();
+process.stdin.setRawMode(true);