From be16cc9fd6399cef5cb892e43a041852a39b8d7d Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Wed, 26 Dec 2018 06:14:54 -0800 Subject: [PATCH] test: set umask for tests https://github.com/nodejs/node/pull/25213 proposes setting umask in the Python test runner to avoid spurious test failures when running from a shell with a restrictive umask. This is a good idea, but will only fix the issue for tests run with the Python runner. Set it in `common/index.js` as well so that it fixes it even when tests are run directly with a `node` binary, bypassing the Python test runner. PR-URL: https://github.com/nodejs/node/pull/25229 Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca Reviewed-By: James M Snell --- test/common/index.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/test/common/index.js b/test/common/index.js index c04cac27bf2eca..c84933fd6eb3b3 100644 --- a/test/common/index.js +++ b/test/common/index.js @@ -34,6 +34,14 @@ const { hasIntl } = process.binding('config'); +// Some tests assume a umask of 0o022 so set that up front. Tests that need a +// different umask will set it themselves. +// +// process.umask() is not available in workers so we need to check for its +// existence. +if (process.umask) + process.umask(0o022); + const noop = () => {}; const hasCrypto = Boolean(process.versions.openssl);