Skip to content

Commit bd8c951

Browse files
bnoordhuisevanlucas
authored andcommitted
tools: disable readability/function cpplint rule
cpplint gets too easily confused by C++ constructs that look like function declarations but aren't. Furthermore, it's arguably a bad rule that conflicts with gcc's -Wunused-parameter flag. PR-URL: #7334 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
1 parent cd38401 commit bd8c951

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

tools/cpplint.py

+5-1
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,11 @@
215215
# flag. By default all errors are on, so only add here categories that should be
216216
# off by default (i.e., categories that must be enabled by the --filter= flags).
217217
# All entries here should start with a '-' or '+', as in the --filter= flag.
218-
_DEFAULT_FILTERS = [ '-build/include_alpha', '-legal/copyright' ]
218+
_DEFAULT_FILTERS = [
219+
'-build/include_alpha',
220+
'-legal/copyright',
221+
'-readability/function',
222+
]
219223

220224
# We used to check for high-bit characters, but after much discussion we
221225
# decided those were OK, as long as they were in UTF-8 and didn't represent

0 commit comments

Comments
 (0)