fixup! src: support namespace options in configuration file

Author: pmarchini

lib/internal/options.js

@@ -42,7 +42,7 @@ function generateConfigJsonSchema() {
   const envOptionsMap = getEnvOptionsInputType();
   const namespaceOptionsMap = getNamespaceOptionsInputType();
 
-  function createPropertyForType(key, type) {
+  function createPropertyForType(type) {
     if (type === 'array') {
       return {
         __proto__: null,
@@ -83,7 +83,7 @@ function generateConfigJsonSchema() {
   // Add env options to nodeOptions (backward compatibility)
   for (const { 0: key, 1: type } of envOptionsMap) {
     const keyWithoutPrefix = StringPrototypeReplace(key, '--', '');
-    nodeOptions[keyWithoutPrefix] = createPropertyForType(key, type);
+    nodeOptions[keyWithoutPrefix] = createPropertyForType(type);
   }
 
   // Add namespace properties at the root level
@@ -101,7 +101,7 @@ function generateConfigJsonSchema() {
     // Add all options for this namespace
     for (const { 0: optionName, 1: optionType } of optionsMap) {
       const keyWithoutPrefix = StringPrototypeReplace(optionName, '--', '');
-      namespaceProperties[keyWithoutPrefix] = createPropertyForType(optionName, optionType);
+      namespaceProperties[keyWithoutPrefix] = createPropertyForType(optionType);
     }
 
     // Sort the namespace properties alphabetically

src/node_config_file.cc

@@ -261,7 +261,7 @@ ParseResult ConfigReader::ParseConfig(const std::string_view& config_path) {
 
     // Check if this field is a valid namespace
     std::string namespace_name(field_name);
-    if (valid_namespaces.find(namespace_name) == valid_namespaces.end()) {
+    if (!valid_namespaces.contains(namespace_name)) {
       // If not, skip it
       continue;
     }
@@ -294,13 +294,13 @@ std::string ConfigReader::GetNodeOptions() {
   std::string acc = "";
   const size_t total_options = node_options_.size();
   acc.reserve(total_options * 2);
-  for (size_t i = 0; i < node_options_.size(); ++i) {
-    acc += " " + node_options_[i];
+  for (auto& opt : node_options_) {
+    acc += " " + opt;
   }
   return acc;
 }
 
-std::vector<std::string> ConfigReader::GetNamespaceFlags() {
+const std::vector<std::string>& ConfigReader::GetNamespaceFlags() const {
   return namespace_options_;
 }
 

src/node_config_file.h

@@ -33,7 +33,7 @@ class ConfigReader {
       const std::vector<std::string>& args);
 
   std::string GetNodeOptions();
-  std::vector<std::string> GetNamespaceFlags();
+  const std::vector<std::string>& GetNamespaceFlags() const;
 
   size_t GetFlagsSize();