Skip to content

Commit bcaf59c

Browse files
addaleaxtargos
authored andcommitted
http2: fix memory leak for uncommon headers
Fix a memory leak that occurs with header names that are short and not present in the static table of default headers. PR-URL: #21336 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
1 parent 17c21b6 commit bcaf59c

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

src/node_http2.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1203,6 +1203,7 @@ class ExternalHeader :
12031203
}
12041204

12051205
if (may_internalize && vec.len < 64) {
1206+
nghttp2_rcbuf_decref(buf);
12061207
// This is a short header name, so there is a good chance V8 already has
12071208
// it internalized.
12081209
return GetInternalizedString(env, vec);

0 commit comments

Comments
 (0)