From bc883fb1362b4923fcd9995f9d8b2fb4e064c8e1 Mon Sep 17 00:00:00 2001
From: cjihrig <cjihrig@gmail.com>
Date: Thu, 1 Feb 2018 10:33:27 -0500
Subject: [PATCH] test: refactor test-http-abort-before-end

This test was added over six years ago, and the behavior
seems to have changed since then. When the test was originally
written, common.mustCall() did not exist. The only assertion
in this test was not actually executing. Instead of an 'error'
event being emitted as expected, an 'abort' event was emitted.

PR-URL: https://github.com/nodejs/node/pull/18508
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
---
 test/parallel/test-http-abort-before-end.js | 19 ++++++++-----------
 1 file changed, 8 insertions(+), 11 deletions(-)

diff --git a/test/parallel/test-http-abort-before-end.js b/test/parallel/test-http-abort-before-end.js
index f8e0272d43e088..4dc2185ad6429b 100644
--- a/test/parallel/test-http-abort-before-end.js
+++ b/test/parallel/test-http-abort-before-end.js
@@ -1,25 +1,22 @@
 'use strict';
 const common = require('../common');
 const http = require('http');
-const assert = require('assert');
 
 const server = http.createServer(common.mustNotCall());
 
-server.listen(0, function() {
+server.listen(0, common.mustCall(() => {
   const req = http.request({
     method: 'GET',
     host: '127.0.0.1',
-    port: this.address().port
+    port: server.address().port
   });
 
-  req.on('error', function(ex) {
-    // https://github.com/joyent/node/issues/1399#issuecomment-2597359
-    // abort() should emit an Error, not the net.Socket object
-    assert(ex instanceof Error);
-  });
+  req.on('abort', common.mustCall(() => {
+    server.close();
+  }));
+
+  req.on('error', common.mustNotCall());
 
   req.abort();
   req.end();
-
-  server.close();
-});
+}));