fix: only generate embedded.cc under Windows. (#12)

nodejs · Jan 5, 2024 · bc718f2 · bc718f2
1 parent 8684549
commit bc718f2
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/tools/v8_gypfiles/v8.gyp b/tools/v8_gypfiles/v8.gyp
@@ -469,20 +469,22 @@
             '<(INTERMEDIATE_DIR)/snapshot.cc',
             '<(INTERMEDIATE_DIR)/embedded.cc',
              ],
+             'action': [
+              '<(python)',
+              '<(V8_ROOT)/tools/snapshot/asm_to_inline_asm.py',
+              '<@(_inputs)',
+              '<(INTERMEDIATE_DIR)/embedded.cc', # important: embedded.cc is only ever generated if OS == "win"
+             ],
             }],
             # Under non-Windows systems, we effectively ignore the output of this
             # action. We do need to build snapshot.cc, however.
             ['OS != "win"', {
-              'outputs': ['<(INTERMEDIATE_DIR)/snapshot.cc']
+              'outputs': ['<(INTERMEDIATE_DIR)/snapshot.cc'],
+              'action': [],
             }],
           ],
           'process_outputs_as_sources': 1,
-          'action': [
-            '<(python)',
-            '<(V8_ROOT)/tools/snapshot/asm_to_inline_asm.py',
-            '<@(_inputs)',
-            '<(INTERMEDIATE_DIR)/embedded.cc',
-          ],
+
         },
       ],
     },  # v8_snapshot