Skip to content

Commit bc25f74

Browse files
committed
tools: de-rollup-ify lint-md
The rollup stuff stopped working with the massive remark ecosystem move to ESM. Rather than try to troubleshoot, simplify things by removing rollup. It's a great tool for a lot of uses, but less may be more here. This does mean checking in a `node_modules` directory so that the linter runs out-of-the-box, like we do for ESLint.
1 parent 3113dbd commit bc25f74

File tree

1,736 files changed

+219623
-93057
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

1,736 files changed

+219623
-93057
lines changed

.github/workflows/linters.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ jobs:
5555
- name: Get release version numbers
5656
if: ${{ github.event.pull_request.base.ref == github.event.pull_request.base.repo.default_branch }}
5757
id: get-released-versions
58-
run: ./tools/node-lint-md-cli-rollup/src/list-released-versions-from-changelogs.mjs
58+
run: ./tools/node-lint-md/list-released-versions-from-changelogs.mjs
5959
- name: Lint docs
6060
run: |
6161
echo "::add-matcher::.github/workflows/remark-lint-problem-matcher.json"

Makefile

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1212,13 +1212,10 @@ bench-addons-clean:
12121212

12131213
.PHONY: lint-md-rollup
12141214
lint-md-rollup:
1215-
$(RM) tools/.*mdlintstamp
1216-
cd tools/node-lint-md-cli-rollup && npm install
1217-
cd tools/node-lint-md-cli-rollup && npm run build-node
1215+
$(warning Deprecated no-op target 'lint-md-rollup')
12181216

12191217
.PHONY: lint-md-clean
12201218
lint-md-clean:
1221-
$(RM) -r tools/node-lint-md-cli-rollup/node_modules
12221219
$(RM) tools/.*mdlintstamp
12231220

12241221
.PHONY: lint-md-build
@@ -1235,7 +1232,7 @@ LINT_MD_TARGETS = doc src lib benchmark test tools/doc tools/icu $(wildcard *.md
12351232
LINT_MD_FILES = $(shell $(FIND) $(LINT_MD_TARGETS) -type f \
12361233
! -path '*node_modules*' ! -path 'test/fixtures/*' -name '*.md' \
12371234
$(LINT_MD_NEWER))
1238-
run-lint-md = tools/lint-md.js -q -f --no-stdout $(LINT_MD_FILES)
1235+
run-lint-md = tools/node-lint-md/cli.mjs -q -f --no-stdout $(LINT_MD_FILES)
12391236
# Lint all changed markdown files maintained by us
12401237
tools/.mdlintstamp: $(LINT_MD_FILES)
12411238
$(info Running Markdown linter...)

0 commit comments

Comments
 (0)