Skip to content

Commit bb75826

Browse files
bnoordhuisMylesBorins
authored andcommitted
test: check result of uv_loop_init and uv_write
Silence coverity warnings about the return value not being checked. PR-URL: #10126 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@chromium.org> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent b498700 commit bb75826

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

test/cctest/test_inspector_socket.cc

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -112,8 +112,9 @@ static void do_write(const char* data, int len) {
112112
uv_buf_t buf[1];
113113
buf[0].base = const_cast<char*>(data);
114114
buf[0].len = len;
115-
uv_write(&req, reinterpret_cast<uv_stream_t*>(&client_socket), buf, 1,
116-
write_done);
115+
GTEST_ASSERT_EQ(0,
116+
uv_write(&req, reinterpret_cast<uv_stream_t*>(&client_socket),
117+
buf, 1, write_done));
117118
SPIN_WHILE(req.data);
118119
}
119120

@@ -351,7 +352,7 @@ class InspectorSocketTest : public ::testing::Test {
351352
connected = false;
352353
inspector_ready = false;
353354
last_event = kInspectorHandshakeHttpGet;
354-
uv_loop_init(&loop);
355+
GTEST_ASSERT_EQ(0, uv_loop_init(&loop));
355356
server = uv_tcp_t();
356357
client_socket = uv_tcp_t();
357358
server.data = &inspector;

0 commit comments

Comments
 (0)