fs: add validateBuffer to improve error

PR-URL: #44769 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
nodejs · Sep 28, 2022 · bb4891d · bb4891d
1 parent 8ec7bfd
commit bb4891d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/fs.js b/lib/fs.js
@@ -632,7 +632,7 @@ function read(fd, buffer, offsetOrOptions, length, position, callback) {
     }
     ({
       offset = 0,
-      length = buffer.byteLength - offset,
+      length = buffer?.byteLength - offset,
       position = null,
     } = params ?? kEmptyObject);
   }

diff --git a/test/parallel/test-fs-read.js b/test/parallel/test-fs-read.js
@@ -79,7 +79,7 @@ assert.throws(
 
 assert.throws(
   () => fs.read(fd, { buffer: null }, common.mustNotCall()),
-  /TypeError: Cannot read properties of null \(reading 'byteLength'\)/,
+  { code: 'ERR_INVALID_ARG_TYPE' },
   'throws when options.buffer is null'
 );