Skip to content

Commit

Permalink
test: refactor test-crypto-pbkdf2
Browse files Browse the repository at this point in the history
* re-order require() and crypto check per test writing guide
* use common.mustNotCall() to confirm callback is not invoked

PR-URL: #13975
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
  • Loading branch information
Trott authored and addaleax committed Jul 18, 2017
1 parent 4ba1d32 commit bb198dc
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions test/parallel/test-crypto-pbkdf2.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
'use strict';
const common = require('../common');
const assert = require('assert');

if (!common.hasCrypto) {
common.skip('missing crypto');
return;
}

const assert = require('assert');
const crypto = require('crypto');

//
Expand Down Expand Up @@ -98,7 +99,7 @@ assert.doesNotThrow(() => {
});

assert.throws(() => {
crypto.pbkdf2('password', 'salt', 8, 8, common.noop);
crypto.pbkdf2('password', 'salt', 8, 8, common.mustNotCall());
}, /^TypeError: The "digest" argument is required and must not be undefined$/);

assert.throws(() => {
Expand Down

0 comments on commit bb198dc

Please sign in to comment.