Skip to content

Commit bac6c85

Browse files
rvaggjasnell
authored andcommitted
doc: add CTC meeting minutes 2016-02-10
PR-URL: #5273 Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 5aebbae commit bac6c85

File tree

1 file changed

+167
-0
lines changed

1 file changed

+167
-0
lines changed

doc/ctc-meetings/2016-02-10.md

Lines changed: 167 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,167 @@
1+
# Node Foundation CTC Meeting 2016-02-10
2+
3+
## Links
4+
5+
* **Audio Recording**: https://soundcloud.com/node-foundation/ctc-meeting-2016-02-10
6+
* **GitHub Issue**: https://github.com/nodejs/node/issues/5176
7+
* **Minutes Google Doc**: <https://docs.google.com/document/d/1sAHu9jVh8Dn9gHFASOH56j2klzW-L6YP-DfKo1gO_6Y>
8+
* _Previous Minutes Google Doc: <https://docs.google.com/document/d/145ND-9pGdAwZ1eoOMypX1_wtx5FCVoanWtLl8zzyxH8>_
9+
10+
## Present
11+
12+
* James Snell (CTC)
13+
* Trevor Norris (CTC)
14+
* Colin Ihrig (CTC)
15+
* Brian White (CTC)
16+
* Alexis Campailla (CTC)
17+
* Bert Belder (CTC)
18+
* Chris Dickinson (CTC)
19+
* Shigeki Ohtsu (CTC)
20+
* Steven Loomis (observer)
21+
* Mikeal Rogers (observer)
22+
* Fedor Indutny (CTC)
23+
* Jeremiah Senkpiel (CTC)
24+
* Rod Vagg (CTC)
25+
* Ben Noordhuis (CTC)
26+
* Nikita Skovoroda (observer)
27+
* Ali Sheikh (observer)
28+
* Evan Lucas (observer)
29+
* Rich Trott (observer)
30+
* Michael Dawson (observer)
31+
32+
## Agenda
33+
34+
Extracted from **ctc-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting.
35+
36+
* Revert "fs: deprecate fs.read's string interface" [#5163](https://github.com/nodejs/node/pull/5163) & fs: add a temporary fix for re-evaluation support [#5102](https://github.com/nodejs/node/pull/5102)
37+
* buffer: add Buffer.from(), Buffer.alloc() and Buffer.allocUnsafe(), soft-deprecate Buffer(num) [#4682](https://github.com/nodejs/node/pull/4682) & Buffer(number) is unsafe [#4660](https://github.com/nodejs/node/issues/4660)
38+
* CTC Membership Nominations [#4750](https://github.com/nodejs/node/issues/4750)
39+
* Seek legal advice on LICENSE and copyright blocks in code [#3979](https://github.com/nodejs/node/issues/3979)
40+
41+
## Standup
42+
43+
* Brian White: Working more on improving performance in various areas of core, reviewing PRs and issues.
44+
* Chris Dickinson: Promises PR + discussions with the error symposium group.
45+
* Rich Trott: addressing flaky tests, enhancing linting, working to find a path to more automation in landing of PRs (although others, including Alexis, seem to have picked that ball up, thankfully)
46+
* James Snell: Working on express stuff in, security stuff out, buffer API finished, moving forward on string externalization.
47+
* Jeremiah Senkpiel: Hook for unhandled rejections that detects when the GC fires on a promise. That is currently blocked on V8 bug with weak callbacks + promises.
48+
* Chris Dickinson: Promises PR + discussions with the error symposium group.
49+
* Trevor Norris — MakeCallback reentrant fix for HTTP parser / AsyncWrap interaction.
50+
* Michael Dawson - Working on getting AIX up in the CI. Also on running v8 tests in the Node tree. Added AIX to libuv tests.
51+
* Steven R. Loomis - not much to add
52+
* Nikita Skovoroda — like ususal, mostly comments and the initial version of the codesearch API on a VPS. Nothing major.
53+
* Rod Vagg - Security stuff, catching up on issues and discussions. Legal committee meeting yesterday.
54+
55+
## Review of last meeting
56+
57+
* Enable Node.js to run with Microsoft's ChakraCore engine [#4765](https://github.com/nodejs/node/pull/4765)
58+
* CTC Membership Nominations [#4750](https://github.com/nodejs/node/issues/4750)
59+
* buffer: add Buffer.from(), Buffer.alloc() and Buffer.allocUnsafe(), soft-deprecate Buffer(num) [#4682](https://github.com/nodejs/node/pull/4682) & Buffer(number) is unsafe [#4660](https://github.com/nodejs/node/issues/4660)
60+
* Seek legal advice on LICENSE and copyright blocks in code [#3979](https://github.com/nodejs/node/issues/3979)
61+
* @srl295: [path for full-icu data?](https://github.com/nodejs/node/issues/3460) - ./node_modules vs ./node/ ? (npm linkage) - todo, update ticket with meeting resolution
62+
63+
64+
## Minutes
65+
66+
### Revert "fs: deprecate fs.read's string interface" [#5163](https://github.com/nodejs/node/pull/5163) & fs: add a temporary fix for re-evaluation support [#5102](https://github.com/nodejs/node/pull/5102)
67+
68+
Rod: Simple deprecation warning for the particular argument usage. Pulling in the internal util module for deprecation messes up older versions of graceful-fs (and thus older versions of npm.) The question is whether to revert the PR, or to add a helper (that Nikita proposed.) I would suggest that this is urgent enough that we need to do something about it.
69+
70+
Jeremiah: This is a poor reason to revert it.
71+
James: From everything that I’ve seen, adding the warning is the least bad option. Folks seems to be against reverting. Maybe making the warning less specific to graceful-fs.
72+
73+
Ben: I don’t agree. I think it’s right to point them to the newer version.
74+
75+
Jeremiah: I agree (with Ben).
76+
77+
Rod: Anytime you break the build, it’s an immediate candidate for reversion. It’s not permanently reverted, but it’s “let’s fix the build.”
78+
79+
Jeremiah: This doesn’t actually break CI though. It breaks newer versions of npm on master. .. It might be npm in general just on the master branch.
80+
81+
James: Forrest noted that pretty much any change other than reverting will have a significant effect on the npm user base.
82+
83+
Jeremiah: Yeah but we’re not shipping this in a stable.
84+
85+
Michael: If it breaks in master, doesn’t that prevent folks from doing other tests?
86+
87+
Ben: I think the problem lies with npm here.
88+
89+
Mikeal: You make that sound so easy.
90+
91+
Ben: The version of npm we’re talking about is still in a PR, yes?
92+
93+
Jeremiah: We don’t regularly run tests on master, so it might already be broken. I can test it right now..
94+
95+
Rod: I think Myles has been trying to run the npm tests more regularly, as part of smoke testing — and it’s broken for the smoke testing now.
96+
97+
Michael: It seems like we’d want to keep things as green as possible. It seems like we’d want npm to do something.
98+
99+
Rod: It’s a fact of life that we exist in an ecosystem that has these kinds of issues. My vote is to revert, and then revisit after we’ve gotten the build fixed.
100+
101+
Ben: Well, yeah, I do. I think Nikita’s PR is an acceptable intermediate solution.
102+
103+
Jeremiah: Likewise. The resolution is that we try to require it, if that fails, we use a deprecation helper we build in that emits a warning that something is breaking an internal module — that would fix it and seems quite reasonable. It will also help people note where stuff is going to break.
104+
105+
Rod: Does someone want to help Nikita get this in?
106+
107+
Ben: Didn’t you already get a couple of LGTMs?
108+
109+
James: I think there’s one -1 and three LGTMs.
110+
111+
Rod: We can force it if we have to.
112+
113+
James: I propose: if we accept this now, let’s try to get it resolved better before v6 goes out — which gives us a deadline so it’s not pushed off indefinitely. npm gets a fix, and that’s where it happens.
114+
115+
Ben: I think it’s a good idea to push npm to update their dependencies. Whether or not npm updates, I think it’s a good idea to include Nikita’s PR.
116+
117+
Jeremiah: I think so too.
118+
119+
Rod: Let’s take it back to GitHub.
120+
121+
### buffer: add Buffer.from(), Buffer.alloc() and Buffer.allocUnsafe(), soft-deprecate Buffer(num) [#4682](https://github.com/nodejs/node/pull/4682) & Buffer(number) is unsafe [#4660](https://github.com/nodejs/node/issues/4660)
122+
123+
James: There were some changes I was waiting for from Trevor w/r/t fill encoding. There was a desire to bikeshed a bit more on the name, not sure if you want to do that here. I think absent that the PR is probably in a place where we can land it.
124+
125+
Rod: Sounds like we need a last call for objections, otherwise it’s going in.
126+
127+
James: Yep.
128+
129+
Rod: How about you do that on GitHub?
130+
131+
James: OK.
132+
133+
Jeremiah: Are you adding a zero-fill flag?
134+
135+
James: Yes — it will switch all allocations to use calloc under the hood. The one thing this does not do is change the default behavior of `new Buffer(size)`. If we did that, it would be a breaking change going back to 0.10.
136+
137+
Bert: Is the plan to deprecate it off the table?
138+
139+
James: It’s a soft deprecate — docs only.
140+
141+
Jeremiah: We should try to just deprecate it. The problem is that folks are running different versions against modules, and it would be bad to rely on zero-fill behavior where it doesn’t exist [CD — didn’t capture this entirely]
142+
143+
James: We need to refine our deprecation strategy — and define whether something is deprecated vs. end-of-life. Will probably be returning to that next week or the week after.
144+
145+
Rod: It sounds like we’ve got a way forward, here.
146+
147+
Bert: It’s ugly but I won’t object.
148+
149+
Rod: Noted.
150+
151+
### CTC Membership Nominations [#4750](https://github.com/nodejs/node/issues/4750)
152+
153+
Rod: We should start to line up a vote.
154+
155+
### Seek legal advice on LICENSE and copyright blocks in code [#3979](https://github.com/nodejs/node/issues/3979)
156+
157+
Rod: There was a PR that Mikeal put in that updates the DCO from v1.0 to v1.1. If you’d like to review that, please comment on that.
158+
159+
### Other business
160+
161+
James noted that the express application landed today. I will be working to move that into the new organization. More of an update on tomorrow’s TSC call.
162+
163+
Jeremiah notes that he will be a bit preoccupied by that for a while.
164+
165+
## Next Meeting
166+
167+
2016-02-17

0 commit comments

Comments
 (0)