Skip to content

Commit b9e1f60

Browse files
decareanoMylesBorins
authored andcommitted
buffer: increase coverage by removing dead code
buffer.js:L196 `if (value == null)` guarantees `obj != null` so L406+L418 are unnecessary. PR-URL: #15100 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 9542844 commit b9e1f60

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

lib/buffer.js

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -374,17 +374,15 @@ function fromObject(obj) {
374374
return b;
375375
}
376376

377-
if (obj != null) {
378-
if (obj.length !== undefined || isAnyArrayBuffer(obj.buffer)) {
379-
if (typeof obj.length !== 'number' || obj.length !== obj.length) {
380-
return new FastBuffer();
381-
}
382-
return fromArrayLike(obj);
377+
if (obj.length !== undefined || isAnyArrayBuffer(obj.buffer)) {
378+
if (typeof obj.length !== 'number' || obj.length !== obj.length) {
379+
return new FastBuffer();
383380
}
381+
return fromArrayLike(obj);
382+
}
384383

385-
if (obj.type === 'Buffer' && Array.isArray(obj.data)) {
386-
return fromArrayLike(obj.data);
387-
}
384+
if (obj.type === 'Buffer' && Array.isArray(obj.data)) {
385+
return fromArrayLike(obj.data);
388386
}
389387
}
390388

0 commit comments

Comments
 (0)