Skip to content

Commit b9a776f

Browse files
committed
[squash] requested changes mentions
1 parent 16787de commit b9a776f

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

doc/onboarding.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,8 +115,10 @@ onboarding session.
115115
usually be addressed even if you don’t use it.
116116
* If you do, it is nice if you are available later to check whether your
117117
comments have been addressed
118-
* Other Collaborators will usually take `Changes requested` to mean that
119-
you are considering some of your comments to block the PR from landing.
118+
* If you see that the requested changes have been made, you can clear another collaborator's
119+
`Changes requested` review.
120+
* Use `Changes requested` to indicate that you are considering some of
121+
your comments to block the PR from landing.
120122

121123
* What belongs in Node.js:
122124
* Opinions vary – it’s good to have a broad collaborator base for that reason!

0 commit comments

Comments
 (0)