Use nullish coalescing to respect zero positional reads

mihilmy · web-flow · commit b83faf96e40a · 2021-11-03T12:22:59.000-07:00
diff --git a/lib/internal/fs/promises.js b/lib/internal/fs/promises.js
@@ -521,7 +521,7 @@ async function read(handle, bufferOrOptions, offset, length, position) {
     }
     offset = bufferOrOptions.offset || 0;
     length = buffer.byteLength;
-    position = bufferOrOptions.position || null;
+    position = bufferOrOptions.position ?? null;
   }
 
   if (offset == null) {

Original file line number	Diff line number	Diff line change
`@@ -521,7 +521,7 @@ async function read(handle, bufferOrOptions, offset, length, position) {`
`521`	`521`	`}`
`522`	`522`	`offset = bufferOrOptions.offset \|\| 0;`
`523`	`523`	`length = buffer.byteLength;`
`524`		`- position = bufferOrOptions.position \|\| null;`
	`524`	`+ position = bufferOrOptions.position ?? null;`
`525`	`525`	`}`
`526`	`526`
`527`	`527`	`if (offset == null) {`