Skip to content

Commit b717956

Browse files
Trottjasnell
authored andcommitted
test: load common.js in all tests
common.js contains code that detects leaked variables. In preparation for an eslint rule that will enforce loading common.js in test files, load it everywhere it can be loaded and use an `eslint-disable` comment for files that intentionally leak. PR-URL: #3157 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent 5d9f83f commit b717956

File tree

10 files changed

+11
-0
lines changed

10 files changed

+11
-0
lines changed

test/addons/async-hello-world/test.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../../common');
23
var assert = require('assert');
34
var binding = require('./build/Release/binding');
45
var called = false;

test/addons/at-exit/test.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
'use strict';
2+
require('../../common');
23
var binding = require('./build/Release/binding');

test/addons/heap-profiler/test.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
'use strict';
22

3+
require('../../common');
4+
35
const binding = require('./build/Release/binding');
46

57
// Create an AsyncWrap object.

test/addons/hello-world-function-export/test.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../../common');
23
var assert = require('assert');
34
var binding = require('./build/Release/binding');
45
assert.equal('world', binding());

test/addons/hello-world/test.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../../common');
23
var assert = require('assert');
34
var binding = require('./build/Release/binding');
45
assert.equal('world', binding.hello());

test/addons/repl-domain-abort/test.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../../common');
23
var assert = require('assert');
34
var repl = require('repl');
45
var stream = require('stream');

test/debugger/test-debugger-repl-break-in-module.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
var repl = require('./helper-debugger-repl.js');
34

45
repl.startDebugger('break-in-module/main.js');

test/debugger/test-debugger-repl-restart.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
var repl = require('./helper-debugger-repl.js');
34

45
repl.startDebugger('breakpoints.js');

test/debugger/test-debugger-repl-term.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
process.env.NODE_FORCE_READLINE = 1;
34

45
var repl = require('./helper-debugger-repl.js');

test/debugger/test-debugger-repl.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
var repl = require('./helper-debugger-repl.js');
34

45
repl.startDebugger('breakpoints.js');

0 commit comments

Comments
 (0)