From b700900d026a2fcbb55c633a12ccbe5aba680001 Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Thu, 29 Oct 2020 19:43:42 +0100 Subject: [PATCH] lib: refactor to use more primordials PR-URL: https://github.com/nodejs/node/pull/35875 Reviewed-By: Rich Trott --- lib/internal/v8_prof_processor.js | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/lib/internal/v8_prof_processor.js b/lib/internal/v8_prof_processor.js index d647d4749f9adc..daae650b2ad8ef 100644 --- a/lib/internal/v8_prof_processor.js +++ b/lib/internal/v8_prof_processor.js @@ -1,6 +1,8 @@ 'use strict'; const { + ArrayPrototypePush, + ArrayPrototypeSlice, JSONStringify, } = primordials; @@ -22,17 +24,18 @@ const scriptFiles = [ ]; let script = ''; -scriptFiles.forEach((s) => { +for (const s of scriptFiles) { script += internalBinding('natives')[s] + '\n'; -}); +} const tickArguments = []; if (process.platform === 'darwin') { - tickArguments.push('--mac'); + ArrayPrototypePush(tickArguments, '--mac'); } else if (process.platform === 'win32') { - tickArguments.push('--windows'); + ArrayPrototypePush(tickArguments, '--windows'); } -tickArguments.push.apply(tickArguments, process.argv.slice(1)); +ArrayPrototypePush(tickArguments, + ...ArrayPrototypeSlice(process.argv, 1)); script = `(function(module, require) { arguments = ${JSONStringify(tickArguments)}; function write (s) { process.stdout.write(s) }