esm: refactor esm tests out of test/message

PR-URL: #41352
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

Author: GeoffreyBooth

test/common/fixtures.js

@@ -2,13 +2,18 @@
 
 const path = require('path');
 const fs = require('fs');
+const { pathToFileURL } = require('url');
 
 const fixturesDir = path.join(__dirname, '..', 'fixtures');
 
 function fixturesPath(...args) {
   return path.join(fixturesDir, ...args);
 }
 
+function fixturesFileURL(...args) {
+  return pathToFileURL(fixturesPath(...args));
+}
+
 function readFixtureSync(args, enc) {
   if (Array.isArray(args))
     return fs.readFileSync(fixturesPath(...args), enc);
@@ -26,6 +31,7 @@ function readFixtureKeys(enc, ...names) {
 module.exports = {
   fixturesDir,
   path: fixturesPath,
+  fileURL: fixturesFileURL,
   readSync: readFixtureSync,
   readKey: readFixtureKey,
   readKeys: readFixtureKeys,

test/common/fixtures.mjs

@@ -3,13 +3,15 @@ import fixtures from './fixtures.js';
 const {
   fixturesDir,
   path,
+  fileURL,
   readSync,
   readKey,
 } = fixtures;
 
 export {
   fixturesDir,
   path,
+  fileURL,
   readSync,
   readKey,
 };

test/es-module/test-esm-export-not-found.mjs

@@ -0,0 +1,39 @@
+import { mustCall } from '../common/index.mjs';
+import { path } from '../common/fixtures.mjs';
+import { match, notStrictEqual } from 'assert';
+import { spawn } from 'child_process';
+import { execPath } from 'process';
+
+const importStatement =
+  'import { foo, notfound } from \'./module-named-exports.mjs\';';
+const importStatementMultiline = `import {
+  foo,
+  notfound
+} from './module-named-exports.mjs';
+`;
+
+[importStatement, importStatementMultiline].forEach((input) => {
+  const child = spawn(execPath, [
+    '--input-type=module',
+    '--eval',
+    input,
+  ], {
+    cwd: path('es-module-loaders'),
+  });
+
+  let stderr = '';
+  child.stderr.setEncoding('utf8');
+  child.stderr.on('data', (data) => {
+    stderr += data;
+  });
+  child.on('close', mustCall((code, _signal) => {
+    notStrictEqual(code, 0);
+
+    // SyntaxError: The requested module './module-named-exports.mjs'
+    // does not provide an export named 'notfound'
+    match(stderr, /SyntaxError:/);
+    // The quotes ensure that the path starts with ./ and not ../
+    match(stderr, /'\.\/module-named-exports\.mjs'/);
+    match(stderr, /notfound/);
+  }));
+});

test/es-module/test-esm-import-json-named-export.mjs

@@ -0,0 +1,25 @@
+import { mustCall } from '../common/index.mjs';
+import { path } from '../common/fixtures.mjs';
+import { match, notStrictEqual } from 'assert';
+import { spawn } from 'child_process';
+import { execPath } from 'process';
+
+const child = spawn(execPath, [
+  '--experimental-json-modules',
+  path('es-modules', 'import-json-named-export.mjs'),
+]);
+
+let stderr = '';
+child.stderr.setEncoding('utf8');
+child.stderr.on('data', (data) => {
+  stderr += data;
+});
+child.on('close', mustCall((code, _signal) => {
+  notStrictEqual(code, 0);
+
+  // SyntaxError: The requested module '../experimental.json'
+  // does not provide an export named 'ofLife'
+  match(stderr, /SyntaxError:/);
+  match(stderr, /'\.\.\/experimental\.json'/);
+  match(stderr, /'ofLife'/);
+}));

test/es-module/test-esm-loader-not-found.mjs

@@ -0,0 +1,27 @@
+import { mustCall } from '../common/index.mjs';
+import { path } from '../common/fixtures.mjs';
+import { match, ok, notStrictEqual } from 'assert';
+import { spawn } from 'child_process';
+import { execPath } from 'process';
+
+const child = spawn(execPath, [
+  '--experimental-loader',
+  'i-dont-exist',
+  path('print-error-message.js'),
+]);
+
+let stderr = '';
+child.stderr.setEncoding('utf8');
+child.stderr.on('data', (data) => {
+  stderr += data;
+});
+child.on('close', mustCall((code, _signal) => {
+  notStrictEqual(code, 0);
+
+  // Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'i-dont-exist'
+  // imported from
+  match(stderr, /ERR_MODULE_NOT_FOUND/);
+  match(stderr, /'i-dont-exist'/);
+
+  ok(!stderr.includes('Bad command or file name'));
+}));

test/es-module/test-esm-loader-obsolete-hooks.mjs

@@ -0,0 +1,30 @@
+import { mustCall } from '../common/index.mjs';
+import { fileURL, path } from '../common/fixtures.mjs';
+import { match, notStrictEqual } from 'assert';
+import { spawn } from 'child_process';
+import { execPath } from 'process';
+
+const child = spawn(execPath, [
+  '--no-warnings',
+  '--throw-deprecation',
+  '--experimental-loader',
+  fileURL('es-module-loaders', 'hooks-obsolete.mjs').href,
+  path('print-error-message.js'),
+]);
+
+let stderr = '';
+child.stderr.setEncoding('utf8');
+child.stderr.on('data', (data) => {
+  stderr += data;
+});
+child.on('close', mustCall((code, _signal) => {
+  notStrictEqual(code, 0);
+
+  // DeprecationWarning: Obsolete loader hook(s) supplied and will be ignored:
+  // dynamicInstantiate, getFormat, getSource, transformSource
+  match(stderr, /DeprecationWarning:/);
+  match(stderr, /dynamicInstantiate/);
+  match(stderr, /getFormat/);
+  match(stderr, /getSource/);
+  match(stderr, /transformSource/);
+}));

test/es-module/test-esm-loader-with-syntax-error.mjs

@@ -0,0 +1,24 @@
+import { mustCall } from '../common/index.mjs';
+import { fileURL, path } from '../common/fixtures.mjs';
+import { match, ok, notStrictEqual } from 'assert';
+import { spawn } from 'child_process';
+import { execPath } from 'process';
+
+const child = spawn(execPath, [
+  '--experimental-loader',
+  fileURL('es-module-loaders', 'syntax-error.mjs').href,
+  path('print-error-message.js'),
+]);
+
+let stderr = '';
+child.stderr.setEncoding('utf8');
+child.stderr.on('data', (data) => {
+  stderr += data;
+});
+child.on('close', mustCall((code, _signal) => {
+  notStrictEqual(code, 0);
+
+  match(stderr, /SyntaxError:/);
+
+  ok(!stderr.includes('Bad command or file name'));
+}));

test/es-module/test-esm-module-not-found-commonjs-hint.mjs

@@ -0,0 +1,35 @@
+import { mustCall } from '../common/index.mjs';
+import { fixturesDir } from '../common/fixtures.mjs';
+import { match, notStrictEqual } from 'assert';
+import { spawn } from 'child_process';
+import { execPath } from 'process';
+
+[
+  {
+    input: 'import "./print-error-message"',
+    // Did you mean to import ../print-error-message.js?
+    expected: / \.\.\/print-error-message\.js\?/,
+  },
+  {
+    input: 'import obj from "some_module/obj"',
+    expected: / some_module\/obj\.js\?/,
+  },
+].forEach(({ input, expected }) => {
+  const child = spawn(execPath, [
+    '--input-type=module',
+    '--eval',
+    input,
+  ], {
+    cwd: fixturesDir,
+  });
+
+  let stderr = '';
+  child.stderr.setEncoding('utf8');
+  child.stderr.on('data', (data) => {
+    stderr += data;
+  });
+  child.on('close', mustCall((code, _signal) => {
+    notStrictEqual(code, 0);
+    match(stderr, expected);
+  }));
+});

test/es-module/test-esm-syntax-error.mjs

@@ -0,0 +1,19 @@
+import { mustCall } from '../common/index.mjs';
+import { path } from '../common/fixtures.mjs';
+import { match, notStrictEqual } from 'assert';
+import { spawn } from 'child_process';
+import { execPath } from 'process';
+
+const child = spawn(execPath, [
+  path('es-module-loaders', 'syntax-error.mjs'),
+]);
+
+let stderr = '';
+child.stderr.setEncoding('utf8');
+child.stderr.on('data', (data) => {
+  stderr += data;
+});
+child.on('close', mustCall((code, _signal) => {
+  notStrictEqual(code, 0);
+  match(stderr, /SyntaxError:/);
+}));