Skip to content

Commit b5825e1

Browse files
committed
assert: improve error check
Minor performance improvement. PR-URL: #17574 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 4e15679 commit b5825e1

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

lib/internal/errors.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -342,11 +342,14 @@ class AssertionError extends Error {
342342
red = '\u001b[31m';
343343
}
344344
const util = lazyUtil();
345-
346-
if (actual && actual.stack && actual instanceof Error)
345+
if (typeof actual === 'object' && actual !== null &&
346+
'stack' in actual && actual instanceof Error) {
347347
actual = `${actual.name}: ${actual.message}`;
348-
if (expected && expected.stack && expected instanceof Error)
348+
}
349+
if (typeof expected === 'object' && expected !== null &&
350+
'stack' in expected && expected instanceof Error) {
349351
expected = `${expected.name}: ${expected.message}`;
352+
}
350353

351354
if (errorDiff === 0) {
352355
let res = util.inspect(actual);

0 commit comments

Comments
 (0)