Skip to content

Commit b48e82e

Browse files
ruyadornojuanarbol
authored andcommitted
tools: add release host var to promotion script
Adds a `NODEJS_RELEASE_HOST` environment variable that enable releasers to provide a custom proxy host to connect to when performing the promotion steps of a given release. Signed-off-by: Ruy Adorno <ruyadorno@google.com> PR-URL: #45913 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
1 parent 7fc7b19 commit b48e82e

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

doc/contributing/releases.md

+8
Original file line numberDiff line numberDiff line change
@@ -827,6 +827,14 @@ or at runtime with:
827827
$ ./tools/release.sh -i ~/.ssh/node_id_rsa
828828
```
829829

830+
You can also specify a different ssh server address to connect to by defining
831+
a `NODEJS_RELEASE_HOST` environment variable:
832+
833+
```console
834+
# Substitute proxy.xyz with whatever address you intend to use
835+
$ NODEJS_RELEASE_HOST=proxy.xyz ./tools/release.sh
836+
```
837+
830838
`tools/release.sh` will perform the following actions when run:
831839

832840
<details>

tools/release.sh

+3-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,9 @@
88

99
set -e
1010

11-
webhost=direct.nodejs.org
11+
[ -z "$NODEJS_RELEASE_HOST" ] && NODEJS_RELEASE_HOST=direct.nodejs.org
12+
13+
webhost=$NODEJS_RELEASE_HOST
1214
webuser=dist
1315
promotablecmd=dist-promotable
1416
promotecmd=dist-promote

0 commit comments

Comments
 (0)