Skip to content

Commit b3a8e95

Browse files
richnologiesMylesBorins
authored andcommitted
test: improve test-assert
Add RegExp to check assert throws the expected AssertionErrors. For the one with multiple flags is ok to hardcode the flags since the spec indicates the ordering will always be `gim`: Refs: http://www.ecma-international.org/ecma-262/6.0/#sec-get-regexp.prototype.flags PR-URL: #10916 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 56970ef commit b3a8e95

File tree

1 file changed

+20
-5
lines changed

1 file changed

+20
-5
lines changed

test/parallel/test-assert.js

Lines changed: 20 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -218,11 +218,26 @@ assert.doesNotThrow(makeBlock(a.deepStrictEqual, /a/g, /a/g));
218218
assert.doesNotThrow(makeBlock(a.deepStrictEqual, /a/i, /a/i));
219219
assert.doesNotThrow(makeBlock(a.deepStrictEqual, /a/m, /a/m));
220220
assert.doesNotThrow(makeBlock(a.deepStrictEqual, /a/igm, /a/igm));
221-
assert.throws(makeBlock(a.deepStrictEqual, /ab/, /a/));
222-
assert.throws(makeBlock(a.deepStrictEqual, /a/g, /a/));
223-
assert.throws(makeBlock(a.deepStrictEqual, /a/i, /a/));
224-
assert.throws(makeBlock(a.deepStrictEqual, /a/m, /a/));
225-
assert.throws(makeBlock(a.deepStrictEqual, /a/igm, /a/im));
221+
assert.throws(
222+
makeBlock(a.deepStrictEqual, /ab/, /a/),
223+
/^AssertionError: \/ab\/ deepStrictEqual \/a\/$/
224+
);
225+
assert.throws(
226+
makeBlock(a.deepStrictEqual, /a/g, /a/),
227+
/^AssertionError: \/a\/g deepStrictEqual \/a\/$/
228+
);
229+
assert.throws(
230+
makeBlock(a.deepStrictEqual, /a/i, /a/),
231+
/^AssertionError: \/a\/i deepStrictEqual \/a\/$/
232+
);
233+
assert.throws(
234+
makeBlock(a.deepStrictEqual, /a/m, /a/),
235+
/^AssertionError: \/a\/m deepStrictEqual \/a\/$/
236+
);
237+
assert.throws(
238+
makeBlock(a.deepStrictEqual, /a/igm, /a/im),
239+
/^AssertionError: \/a\/gim deepStrictEqual \/a\/im$/
240+
);
226241

227242
{
228243
const re1 = /a/;

0 commit comments

Comments
 (0)