From b368571fba2bd7bceb18a3ef64d20769ca13bd27 Mon Sep 17 00:00:00 2001 From: cjihrig Date: Mon, 15 Apr 2019 11:43:56 -0400 Subject: [PATCH] test: move known issue test to parallel As of libuv 1.28.0, this bug is fixed, and the test can be moved to parallel. This commit also updates an error code check to work on Windows. PR-URL: https://github.com/nodejs/node/pull/27241 Reviewed-By: Richard Lau Reviewed-By: Ruben Bridgewater Reviewed-By: James M Snell Reviewed-By: Rich Trott Reviewed-By: Anna Henningsen Reviewed-By: Ben Noordhuis --- .../test-fs-copyfile-respect-permissions.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) rename test/{known_issues => parallel}/test-fs-copyfile-respect-permissions.js (90%) diff --git a/test/known_issues/test-fs-copyfile-respect-permissions.js b/test/parallel/test-fs-copyfile-respect-permissions.js similarity index 90% rename from test/known_issues/test-fs-copyfile-respect-permissions.js rename to test/parallel/test-fs-copyfile-respect-permissions.js index 34697eea6c0bef..2021e9ba63155d 100644 --- a/test/known_issues/test-fs-copyfile-respect-permissions.js +++ b/test/parallel/test-fs-copyfile-respect-permissions.js @@ -23,7 +23,8 @@ function beforeEach() { fs.chmodSync(dest, '444'); const check = (err) => { - assert.strictEqual(err.code, 'EACCES'); + const expected = ['EACCES', 'EPERM']; + assert(expected.includes(err.code), `${err.code} not in ${expected}`); assert.strictEqual(fs.readFileSync(dest, 'utf8'), 'dest'); return true; };