src: remove erroneous default argument in RadixTree

tniessen · tniessen · commit b2b31398d31c · 2023-11-15T00:38:02.000Z
This default argument can never benefit any potential caller because any
call site that occurs after this definition will result in a compiler
error due to RadixTree::Lookup(const std::string_view&amp;) now being an
ambiguous call target.
diff --git a/src/permission/fs_permission.cc b/src/permission/fs_permission.cc
@@ -171,7 +171,7 @@ FSPermission::RadixTree::~RadixTree() {
 }
 
 bool FSPermission::RadixTree::Lookup(const std::string_view& s,
-                                     bool when_empty_return = false) {
+                                     bool when_empty_return) {
   FSPermission::RadixTree::Node* current_node = root_node_;
   if (current_node->children.size() == 0) {
     return when_empty_return;

Original file line number	Diff line number	Diff line change
`@@ -171,7 +171,7 @@ FSPermission::RadixTree::~RadixTree() {`
`171`	`171`	`}`
`172`	`172`
`173`	`173`	`bool FSPermission::RadixTree::Lookup(const std::string_view& s,`
`174`		`- bool when_empty_return = false) {`
	`174`	`+ bool when_empty_return) {`
`175`	`175`	`FSPermission::RadixTree::Node* current_node = root_node_;`
`176`	`176`	`if (current_node->children.size() == 0) {`
`177`	`177`	`return when_empty_return;`