Skip to content

Commit b2a08fb

Browse files
TrottMylesBorins
authored andcommitted
tools: replace custom new-with-error rule
Use no-restricted-syntax to implement the requirement that `Error` objects must be thrown with the `new` keyword. PR-URL: #12249 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
1 parent 19d9551 commit b2a08fb

File tree

2 files changed

+5
-34
lines changed

2 files changed

+5
-34
lines changed

.eslintrc.yaml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -109,8 +109,11 @@ rules:
109109
message: "setTimeout() must be invoked with at least two arguments."
110110
}, {
111111
selector: "CallExpression[callee.name='setInterval'][arguments.length<2]",
112-
message: "setInterval() must be invoked with at least 2 arguments"
113-
}]
112+
message: "setInterval() must be invoked with at least 2 arguments."
113+
}, {
114+
selector: "ThrowStatement > CallExpression[callee.name=/Error$/]",
115+
message: "Use new keyword when throwing an Error."
116+
}]
114117
no-tabs: 2
115118
no-trailing-spaces: 2
116119
operator-linebreak: [2, after, {overrides: {'?': ignore, ':': ignore}}]
@@ -142,7 +145,6 @@ rules:
142145
align-multiline-assignment: 2
143146
assert-fail-single-argument: 2
144147
assert-throws-arguments: [2, { requireTwo: false }]
145-
new-with-error: [2, Error, RangeError, TypeError, SyntaxError, ReferenceError]
146148
no-useless-regex-char-class-escape: [2, { override: ['[', ']'] }]
147149

148150
# Global scoped method and vars

tools/eslint-rules/new-with-error.js

Lines changed: 0 additions & 31 deletions
This file was deleted.

0 commit comments

Comments
 (0)