Skip to content

Commit b180a15

Browse files
committed
build: only emit download ICU warnings once
The check that the user specified `icu` in `--download` only needs to be done once and not for each entry in `tools/icu/current_ver.dep`. Fixes: #26860 PR-URL: #27031 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 15c0947 commit b180a15

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

configure.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1253,13 +1253,14 @@ def icu_download(path):
12531253
if not os.access(options.download_path, os.W_OK):
12541254
error('''Cannot write to desired download path.
12551255
Either create it or verify permissions.''')
1256+
attemptdownload = nodedownload.candownload(auto_downloads, "icu")
12561257
for icu in icus:
12571258
url = icu['url']
12581259
md5 = icu['md5']
12591260
local = url.split('/')[-1]
12601261
targetfile = os.path.join(options.download_path, local)
12611262
if not os.path.isfile(targetfile):
1262-
if nodedownload.candownload(auto_downloads, "icu"):
1263+
if attemptdownload:
12631264
nodedownload.retrievefile(url, targetfile)
12641265
else:
12651266
print('Re-using existing %s' % targetfile)

0 commit comments

Comments
 (0)