Skip to content

Commit

Permalink
async_hooks,test: only use IPv6 in http test
Browse files Browse the repository at this point in the history
If IPv6 is not supported on a machine, the IPv6 handle will first be
created, this will then fail and default to an IPv4 handle. This causes
the graph to change, as there now is an extra handle.

PR-URL: #18143
Fixes: #18003
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
AndreasMadsen authored and apapirovski committed Jan 14, 2018
1 parent 8d04323 commit b12425d
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion test/async-hooks/test-graph.http.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
'use strict';

const common = require('../common');
if (!common.hasIPv6)
common.skip('IPv6 support required');

const initHooks = require('./init-hooks');
const verifyGraph = require('./verify-graph');
const http = require('http');
Expand All @@ -13,7 +16,11 @@ const server = http.createServer(common.mustCall(function(req, res) {
this.close(common.mustCall());
}));
server.listen(0, common.mustCall(function() {
http.get(`http://127.0.0.1:${server.address().port}`, common.mustCall());
http.get({
host: '::1',
family: 6,
port: server.address().port
}, common.mustCall());
}));

process.on('exit', function() {
Expand Down

0 comments on commit b12425d

Please sign in to comment.