Skip to content

Commit ae81a04

Browse files
joyeecheungMylesBorins
authored andcommitted
util: skip type checks in internal getSystemErrorName
Backport-PR-URL: #19191 PR-URL: #18546 Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent ff693d2 commit ae81a04

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

lib/internal/util.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -202,11 +202,6 @@ function getConstructorOf(obj) {
202202
}
203203

204204
function getSystemErrorName(err) {
205-
if (typeof err !== 'number' || err >= 0 || !Number.isSafeInteger(err)) {
206-
throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'err',
207-
'negative number');
208-
}
209-
210205
const entry = errmap.get(err);
211206
return entry ? entry[0] : `Unknown system error ${err}`;
212207
}

lib/util.js

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ const {
5050
customInspectSymbol,
5151
deprecate,
5252
getConstructorOf,
53-
getSystemErrorName,
53+
getSystemErrorName: internalErrorName,
5454
isError,
5555
promisify,
5656
join
@@ -1065,6 +1065,14 @@ function callbackify(original) {
10651065
return callbackified;
10661066
}
10671067

1068+
function getSystemErrorName(err) {
1069+
if (typeof err !== 'number' || err >= 0 || !Number.isSafeInteger(err)) {
1070+
throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'err',
1071+
'negative number');
1072+
}
1073+
return internalErrorName(err);
1074+
}
1075+
10681076
// Keep the `exports =` so that various functions can still be monkeypatched
10691077
module.exports = exports = {
10701078
_errnoException,

0 commit comments

Comments
 (0)