Skip to content

Commit

Permalink
test: fix weird string error
Browse files Browse the repository at this point in the history
Previously getting this error when running `tap2junit` (what parses our
`.tap` files in CI):

```
Traceback (most recent call last):
  File "/usr/local/bin/tap2junit", line 11, in <module>
    sys.exit(main())
  File "/usr/local/lib/python2.7/site-packages/tap2junit/__main__.py", line 46, in main
    result.to_file(args.output, [result], prettyprint=False)
  File "/usr/local/lib/python2.7/site-packages/junit_xml/__init__.py", line 289, in to_file
    test_suites, prettyprint=prettyprint, encoding=encoding)
  File "/usr/local/lib/python2.7/site-packages/junit_xml/__init__.py", line 257, in to_xml_string
    ts_xml = ts.build_xml_doc(encoding=encoding)
  File "/usr/local/lib/python2.7/site-packages/junit_xml/__init__.py", line 221, in build_xml_doc
    attrs['message'] = decode(case.skipped_message, encoding)
  File "/usr/local/lib/python2.7/site-packages/junit_xml/__init__.py", line 68, in decode
    ret = unicode(var)
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 11: ordinal not in range(128)
```

PR-URL: #21793
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
maclover7 authored and targos committed Jul 14, 2018
1 parent 712809e commit ada3f34
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion test/parallel/test-stdio-pipe-access.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';
const common = require('../common');
if (!common.isMainThread)
common.skip('Workers dont have process-like stdio');
common.skip("Workers don't have process-like stdio");

// Test if Node handles acessing process.stdin if it is a redirected
// pipe without deadlocking
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-stdio-pipe-redirect.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';
const common = require('../common');
if (!common.isMainThread)
common.skip('Workers dont have process-like stdio');
common.skip("Workers don't have process-like stdio");

// Test if Node handles redirecting one child process stdout to another
// process stdin without crashing.
Expand Down

0 comments on commit ada3f34

Please sign in to comment.