From aaf783443b2c0894127d39832b2b6c906c62ec6b Mon Sep 17 00:00:00 2001 From: Santiago Gimeno Date: Fri, 4 Nov 2016 11:01:26 +0100 Subject: [PATCH] test: fix flaky test-force-repl-with-eval MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Remove the timer just in case the test takes longer to complete. PR-URL: https://github.com/nodejs/node/pull/9460 Reviewed-By: Colin Ihrig Reviewed-By: Rich Trott Reviewed-By: Michaël Zasso --- test/parallel/test-force-repl-with-eval.js | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/test/parallel/test-force-repl-with-eval.js b/test/parallel/test-force-repl-with-eval.js index a285db8e57d930..e5044ba59df4d5 100644 --- a/test/parallel/test-force-repl-with-eval.js +++ b/test/parallel/test-force-repl-with-eval.js @@ -1,14 +1,11 @@ 'use strict'; -const common = require('../common'); +require('../common'); const assert = require('assert'); const spawn = require('child_process').spawn; // spawn a node child process in "interactive" mode (force the repl) and eval const cp = spawn(process.execPath, ['-i', '-e', 'console.log("42")']); var gotToEnd = false; -const timeoutId = setTimeout(function() { - throw new Error('timeout!'); -}, common.platformTimeout(1000)); // give node + the repl 1 second to boot up cp.stdout.setEncoding('utf8'); @@ -16,7 +13,6 @@ var output = ''; cp.stdout.on('data', function(b) { output += b; if (output === '> 42\n') { - clearTimeout(timeoutId); gotToEnd = true; cp.kill(); }