tty: enable buffering

HWM was set to 0 which would cause e.g. stdout.write(...) to always return false. Refs: #39246 PR-URL: #39253 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
nodejs · Jul 7, 2021 · a8a8638 · a8a8638
1 parent 9b68d84
commit a8a8638
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/lib/tty.js b/lib/tty.js
@@ -57,7 +57,7 @@ function ReadStream(fd, options) {
   }
 
   net.Socket.call(this, {
-    highWaterMark: 0,
+    readableHighWaterMark: 0,
     handle: tty,
     manualStart: true,
     ...options
@@ -94,7 +94,7 @@ function WriteStream(fd) {
   }
 
   net.Socket.call(this, {
-    highWaterMark: 0,
+    readableHighWaterMark: 0,
     handle: tty,
     manualStart: true
   });

diff --git a/test/parallel/test-stdout-stderr-write.js b/test/parallel/test-stdout-stderr-write.js
@@ -0,0 +1,8 @@
+'use strict';
+
+require('../common');
+const assert = require('assert');
+
+// https://github.com/nodejs/node/pull/39246
+assert.strictEqual(process.stderr.write('asd'), true);
+assert.strictEqual(process.stdout.write('asd'), true);