Commit a8840bb
deps: cherry-pick 3c39bac from V8 upstream
Original commit message:
Don't skip hole checks inside patterns in parameter lists
Previously, b6e9f625c17f3a688139426771e2cb34fbdcb46e fixed self-assignment
in parameters to throw. But it failed to deal with the case of
destructuring with defaults. This patch extends that previous approach
to always treat the end of a parameter as its initializer position,
whether it has an initializer or not.
This is the minimal change to make it easy to merge; a follow-up
will rename the field of Parameter from "initializer_end_position"
to "end_position".
BUG=v8:5454
Review-Url: https://codereview/chromium.org/2390943002
Cr-Commit-Position: refs/heads/master@{#39962}
PR-URL: #9138
Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>1 parent 4f25236 commit a8840bb
File tree
3 files changed
+13
-6
lines changed- deps/v8
- include
- src/parsing
- test/mjsunit/regress
3 files changed
+13
-6
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4445 | 4445 | | |
4446 | 4446 | | |
4447 | 4447 | | |
4448 | | - | |
4449 | | - | |
4450 | | - | |
4451 | 4448 | | |
4452 | 4449 | | |
4453 | 4450 | | |
| |||
4465 | 4462 | | |
4466 | 4463 | | |
4467 | 4464 | | |
4468 | | - | |
4469 | 4465 | | |
4470 | 4466 | | |
4471 | 4467 | | |
| |||
4490 | 4486 | | |
4491 | 4487 | | |
4492 | 4488 | | |
4493 | | - | |
| 4489 | + | |
4494 | 4490 | | |
4495 | 4491 | | |
4496 | 4492 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
0 commit comments