Skip to content

Commit

Permalink
test: using const and strictEqual
Browse files Browse the repository at this point in the history
PR-URL: #9926
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
ftatieze authored and MylesBorins committed Dec 21, 2016
1 parent 86514e7 commit a7e34e0
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 14 deletions.
10 changes: 5 additions & 5 deletions test/parallel/test-console-instance.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ process.stdout.write = process.stderr.write = function() {
};

// make sure that the "Console" function exists
assert.equal('function', typeof Console);
assert.strictEqual('function', typeof Console);

// make sure that the Console constructor throws
// when not given a writable stream instance
Expand All @@ -35,7 +35,7 @@ out.write = err.write = function(d) {};
var c = new Console(out, err);

out.write = err.write = function(d) {
assert.equal(d, 'test\n');
assert.strictEqual(d, 'test\n');
called = true;
};

Expand All @@ -48,7 +48,7 @@ c.error('test');
assert(called);

out.write = function(d) {
assert.equal('{ foo: 1 }\n', d);
assert.strictEqual('{ foo: 1 }\n', d);
called = true;
};

Expand All @@ -60,10 +60,10 @@ assert(called);
called = 0;
out.write = function(d) {
called++;
assert.equal(d, called + ' ' + (called - 1) + ' [ 1, 2, 3 ]\n');
assert.strictEqual(d, called + ' ' + (called - 1) + ' [ 1, 2, 3 ]\n');
};
[1, 2, 3].forEach(c.log);
assert.equal(3, called);
assert.strictEqual(3, called);

// Console() detects if it is called without `new` keyword
assert.doesNotThrow(function() {
Expand Down
18 changes: 9 additions & 9 deletions test/parallel/test-dgram-msgsize.js
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
'use strict';
var common = require('../common');
var assert = require('assert');
var dgram = require('dgram');
const common = require('../common');
const assert = require('assert');
const dgram = require('dgram');

// Send a too big datagram. The destination doesn't matter because it's
// not supposed to get sent out anyway.
var buf = Buffer(256 * 1024);
var sock = dgram.createSocket('udp4');
const buf = Buffer.allocUnsafe(256 * 1024);
const sock = dgram.createSocket('udp4');
sock.send(buf, 0, buf.length, 12345, '127.0.0.1', common.mustCall(cb));
function cb(err) {
assert(err instanceof Error);
assert.equal(err.code, 'EMSGSIZE');
assert.equal(err.address, '127.0.0.1');
assert.equal(err.port, 12345);
assert.equal(err.message, 'send EMSGSIZE 127.0.0.1:12345');
assert.strictEqual(err.code, 'EMSGSIZE');
assert.strictEqual(err.address, '127.0.0.1');
assert.strictEqual(err.port, 12345);
assert.strictEqual(err.message, 'send EMSGSIZE 127.0.0.1:12345');
sock.close();
}

0 comments on commit a7e34e0

Please sign in to comment.