src: merge fn_name in NODE_SET_PROTOTYPE_METHOD

XadillaX · addaleax · commit a5f415fe8309 · 2017-06-12T14:20:00.000+02:00
Merge two duplicate `fn_name` into one in NODE_SET_PROTOTYPE_METHOD, it may improve a bit performance. PR-URL: #13547 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/src/node.h b/src/node.h
@@ -293,7 +293,7 @@ inline void NODE_SET_PROTOTYPE_METHOD(v8::Local<v8::FunctionTemplate> recv,
       v8::FunctionTemplate::New(isolate, callback, v8::Local<v8::Value>(), s);
   v8::Local<v8::String> fn_name = v8::String::NewFromUtf8(isolate, name);
   t->SetClassName(fn_name);
-  recv->PrototypeTemplate()->Set(v8::String::NewFromUtf8(isolate, name), t);
+  recv->PrototypeTemplate()->Set(fn_name, t);
 }
 #define NODE_SET_PROTOTYPE_METHOD node::NODE_SET_PROTOTYPE_METHOD
 

Original file line number	Diff line number	Diff line change
`@@ -293,7 +293,7 @@ inline void NODE_SET_PROTOTYPE_METHOD(v8::Local<v8::FunctionTemplate> recv,`
`293`	`293`	`v8::FunctionTemplate::New(isolate, callback, v8::Local<v8::Value>(), s);`
`294`	`294`	`v8::Local<v8::String> fn_name = v8::String::NewFromUtf8(isolate, name);`
`295`	`295`	`t->SetClassName(fn_name);`
`296`		`- recv->PrototypeTemplate()->Set(v8::String::NewFromUtf8(isolate, name), t);`
	`296`	`+ recv->PrototypeTemplate()->Set(fn_name, t);`
`297`	`297`	`}`
`298`	`298`	`#define NODE_SET_PROTOTYPE_METHOD node::NODE_SET_PROTOTYPE_METHOD`
`299`	`299`