Skip to content

Commit a42b93b

Browse files
Uzlopaktargos
authored andcommitted
util: improve isInsideNodeModules
PR-URL: #52147 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 7f866a8 commit a42b93b

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

lib/internal/util.js

+7-2
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ const {
3535
SafeSet,
3636
SafeWeakMap,
3737
SafeWeakRef,
38+
StringPrototypeIncludes,
3839
StringPrototypeReplace,
3940
StringPrototypeToLowerCase,
4041
StringPrototypeToUpperCase,
@@ -476,7 +477,7 @@ function spliceOne(list, index) {
476477
list.pop();
477478
}
478479

479-
const kNodeModulesRE = /^(.*)[\\/]node_modules[\\/]/;
480+
const kNodeModulesRE = /^(?:.*)[\\/]node_modules[\\/]/;
480481

481482
let getStructuredStack;
482483

@@ -506,8 +507,12 @@ function isInsideNodeModules() {
506507
const filename = frame.getFileName();
507508
// If a filename does not start with / or contain \,
508509
// it's likely from Node.js core.
509-
if (RegExpPrototypeExec(/^\/|\\/, filename) === null)
510+
if (
511+
filename[0] !== '/' &&
512+
StringPrototypeIncludes(filename, '\\') === false
513+
) {
510514
continue;
515+
}
511516
return RegExpPrototypeExec(kNodeModulesRE, filename) !== null;
512517
}
513518
}

0 commit comments

Comments
 (0)