Skip to content

Commit a30f5b3

Browse files
ronagMylesBorins
authored andcommitted
http: add note about timer unref
PR-URL: #34143 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent 8811058 commit a30f5b3

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

lib/_http_server.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -568,6 +568,10 @@ function socketOnData(server, socket, parser, state, d) {
568568
}
569569

570570
function onParserExecute(server, socket, parser, state, ret) {
571+
// When underlying `net.Socket` instance is consumed - no
572+
// `data` events are emitted, and thus `socket.setTimeout` fires the
573+
// callback even if the data is constantly flowing into the socket.
574+
// See, https://github.com/nodejs/node/commit/ec2822adaad76b126b5cccdeaa1addf2376c9aa6
571575
socket._unrefTimer();
572576
debug('SERVER socketOnParserExecute %d', ret);
573577
onParserExecuteCommon(server, socket, parser, state, ret, undefined);

0 commit comments

Comments
 (0)