Skip to content

Commit a2c8de7

Browse files
sungpaksruyadorno
authored andcommitted
events: add hasEventListener util for validate
There was some repetitive logics that validated the existence of eventlisteners. We now replace this with a single line of, `hasEventListener(self, type)`. `self` is the object(e.g. EventEmitter) to be checked whether eventlisteners exists or not. `type` is the type of eventlisteners, which can be `undefined` PR-URL: #55230 Reviewed-By: Jason Zhang <xzha4350@gmail.com>
1 parent 27b0236 commit a2c8de7

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

lib/events.js

+12-12
Original file line numberDiff line numberDiff line change
@@ -287,6 +287,12 @@ ObjectDefineProperty(EventEmitter, 'defaultMaxListeners', {
287287
},
288288
});
289289

290+
function hasEventListener(self, type) {
291+
if (type === undefined)
292+
return self._events !== undefined;
293+
return self._events !== undefined && self._events[type] !== undefined;
294+
};
295+
290296
ObjectDefineProperties(EventEmitter, {
291297
kMaxEventTargetListeners: {
292298
__proto__: null,
@@ -680,13 +686,11 @@ EventEmitter.prototype.removeListener =
680686
function removeListener(type, listener) {
681687
checkListener(listener);
682688

683-
const events = this._events;
684-
if (events === undefined)
689+
if (!hasEventListener(this, type))
685690
return this;
686691

692+
const events = this._events;
687693
const list = events[type];
688-
if (list === undefined)
689-
return this;
690694

691695
if (list === listener || list.listener === listener) {
692696
this._eventsCount -= 1;
@@ -740,9 +744,9 @@ EventEmitter.prototype.off = EventEmitter.prototype.removeListener;
740744
*/
741745
EventEmitter.prototype.removeAllListeners =
742746
function removeAllListeners(type) {
743-
const events = this._events;
744-
if (events === undefined)
747+
if (!hasEventListener(this))
745748
return this;
749+
const events = this._events;
746750

747751
// Not listening for removeListener, no need to emit
748752
if (events.removeListener === undefined) {
@@ -787,14 +791,10 @@ EventEmitter.prototype.removeAllListeners =
787791
};
788792

789793
function _listeners(target, type, unwrap) {
790-
const events = target._events;
791-
792-
if (events === undefined)
794+
if (!hasEventListener(target, type))
793795
return [];
794796

795-
const evlistener = events[type];
796-
if (evlistener === undefined)
797-
return [];
797+
const evlistener = target._events[type];
798798

799799
if (typeof evlistener === 'function')
800800
return unwrap ? [evlistener.listener || evlistener] : [evlistener];

0 commit comments

Comments
 (0)