Skip to content

Commit a1a850f

Browse files
gibfahnMylesBorins
authored andcommitted
test: don't connect to :: (use localhost instead)
If a test does http.listen(0) or net.listen(0), http.listen(0).address().address returns '::'. Some machines will resolve this to localhost, but not all. Every machine should have localhost defined in /etc/hosts (or equivalent), so it should always resolve. Fixes: #7291
1 parent 22c25de commit a1a850f

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

test/gc/test-net-timeout.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ function getall() {
3636
return;
3737

3838
(function() {
39-
var req = net.connect(server.address().port, server.address().address);
39+
var req = net.connect(server.address().port);
4040
req.resume();
4141
req.setTimeout(10, function() {
4242
//console.log('timeout (expected)')

test/parallel/test-http-status-reason-invalid-chars.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
const common = require('../common');
44
const assert = require('assert');
55
const http = require('http');
6-
const net = require('net');
76

87
function explicit(req, res) {
98
assert.throws(() => {
@@ -34,8 +33,7 @@ const server = http.createServer((req, res) => {
3433
implicit(req, res);
3534
}
3635
}).listen(0, common.mustCall(() => {
37-
const addr = server.address().address;
38-
const hostname = net.isIPv6(addr) ? `[${addr}1]` : addr;
36+
const hostname = 'localhost';
3937
const url = `http://${hostname}:${server.address().port}`;
4038
let left = 2;
4139
const check = common.mustCall((res) => {

0 commit comments

Comments
 (0)