sqlite: refactor authz code validation logic

Author: araujogui

src/node_sqlite.cc

@@ -1967,8 +1967,8 @@ int DatabaseSync::AuthorizerCallback(void* user_data,
   }
 
   Local<Value> result;
-  if (!retval.ToLocal(&result) || result->IsUndefined() || result->IsNull()) {
-    // Missing return value
+  if (!retval.ToLocal(&result) || result->IsUndefined() || result->IsNull() ||
+      !result->IsInt32()) {
     Local<Value> err = Exception::TypeError(
         String::NewFromUtf8(
             isolate,
@@ -1978,15 +1978,6 @@ int DatabaseSync::AuthorizerCallback(void* user_data,
     return SQLITE_DENY;
   }
 
-  if (!result->IsInt32()) {
-    Local<Value> err = Exception::TypeError(
-        String::NewFromUtf8(
-            isolate, "Authorizer callback return value must be an integer")
-            .ToLocalChecked());
-    db->StoreAuthorizerError(err);
-    return SQLITE_DENY;
-  }
-
   int32_t int_result = result.As<Int32>()->Value();
   if (int_result != SQLITE_OK && int_result != SQLITE_DENY &&
       int_result != SQLITE_IGNORE) {

test/parallel/test-sqlite-authz.js

@@ -105,7 +105,7 @@ suite('DatabaseSync.prototype.setAuthorizer()', () => {
     assert.throws(() => {
       db.exec('SELECT 1');
     }, {
-      message: 'Authorizer callback return value must be an integer'
+      message: 'Authorizer callback must return an integer authorization code'
     });
   });