url: overload canParse V8 fast api method

nodejs · Aug 1, 2023 · a0bdd05 · a0bdd05
1 parent 9df9c71
commit a0bdd05
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/lib/internal/url.js b/lib/internal/url.js
@@ -1054,10 +1054,10 @@ class URL {
     url = `${url}`;
 
     if (base !== undefined) {
-      return bindingUrl.canParseWithBase(url, `${base}`);
+      base = `${base}`;
     }
 
-    return bindingUrl.canParse(url);
+    return bindingUrl.canParse(url, base);
   }
 }
 

diff --git a/src/node_url.cc b/src/node_url.cc
@@ -360,13 +360,14 @@ void BindingData::CreatePerIsolateProperties(IsolateData* isolate_data,
   SetMethodNoSideEffect(isolate, target, "getOrigin", GetOrigin);
   SetMethod(isolate, target, "parse", Parse);
   SetMethod(isolate, target, "update", Update);
-  SetFastMethodNoSideEffect(
-      isolate, target, "canParse", CanParse, &fast_can_parse_);
-  SetFastMethodNoSideEffect(isolate,
-                            target,
-                            "canParseWithBase",
-                            CanParse,
-                            &fast_can_parse_with_base_);
+
+  const v8::CFunction fast_can_parse_methods[] = {fast_can_parse_, fast_can_parse_with_base_};
+  SetFastMethodNoSideEffectOverloads(
+      isolate,
+      target,
+      "canParse",
+      CanParse,
+      {fast_can_parse_methods, 2});
 }
 
 void BindingData::CreatePerContextProperties(Local<Object> target,

diff --git a/typings/internalBinding/url.d.ts b/typings/internalBinding/url.d.ts
@@ -6,7 +6,6 @@ declare function InternalBinding(binding: 'url'): {
   domainToASCII(input: string): string;
   domainToUnicode(input: string): string;
   canParse(input: string): boolean;
-  canParseWithBase(input: string, base: string): boolean;
   format(input: string, fragment?: boolean, unicode?: boolean, search?: boolean, auth?: boolean): string;
   parse(input: string, base?: string): string | false;
   update(input: string, actionType: typeof urlUpdateActions, value: string): string | false;