Skip to content

Commit

Permalink
benchmark: fix comment typos and code format
Browse files Browse the repository at this point in the history
I noticed some typos and the lack of {} following an if.

PR-URL: #7961
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
  • Loading branch information
adrian-nitu-92 authored and AndreasMadsen committed Aug 12, 2016
1 parent b9832eb commit 9e7fd8e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 5 additions & 5 deletions benchmark/common.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ function Benchmark(fn, options) {
Benchmark.prototype._parseArgs = function(argv, options) {
const cliOptions = Object.assign({}, options);

// Parse configuarion arguments
// Parse configuration arguments
for (const arg of argv) {
const match = arg.match(/^(.+?)=([\s\S]*)$/);
if (!match || !match[1]) {
Expand All @@ -52,7 +52,7 @@ Benchmark.prototype._queue = function(options) {
const queue = [];
const keys = Object.keys(options);

// Perform a depth-first walk though all options to genereate a
// Perform a depth-first walk though all options to generate a
// configuration list that contains all combinations.
function recursive(keyIndex, prevConfig) {
const key = keys[keyIndex];
Expand Down Expand Up @@ -171,9 +171,9 @@ Benchmark.prototype._run = function() {
};

Benchmark.prototype.start = function() {
if (this._started)
if (this._started) {
throw new Error('Called start more than once in a single benchmark');

}
this._started = true;
this._time = process.hrtime();
};
Expand All @@ -195,7 +195,7 @@ Benchmark.prototype.end = function(operations) {
};

function formatResult(data) {
// Construct confiuration string, " A=a, B=b, ..."
// Construct configuration string, " A=a, B=b, ..."
let conf = '';
for (const key of Object.keys(data.conf)) {
conf += ' ' + key + '=' + JSON.stringify(data.conf[key]);
Expand Down
2 changes: 1 addition & 1 deletion benchmark/compare.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ console.log('"binary", "filename", "configuration", "rate", "time"');
}
conf = conf.slice(1);

// Escape qoutes (") for correct csv formatting
// Escape quotes (") for correct csv formatting
conf = conf.replace(/"/g, '""');

console.log(`"${job.binary}", "${job.filename}", "${conf}", ` +
Expand Down

0 comments on commit 9e7fd8e

Please sign in to comment.