From 9b7362c460c0bd3073fd96c0151f4b670fece27a Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Thu, 15 Aug 2019 15:49:34 +0200 Subject: [PATCH] http2: remove unused FlushData() function MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR-URL: https://github.com/nodejs/node/pull/29145 Reviewed-By: Michaël Zasso Reviewed-By: Colin Ihrig Reviewed-By: Jiawen Geng Reviewed-By: Luigi Pinca Reviewed-By: Rich Trott Reviewed-By: Trivikram Kamat Reviewed-By: James M Snell --- src/node_http2.cc | 9 --------- src/node_http2.h | 1 - 2 files changed, 10 deletions(-) diff --git a/src/node_http2.cc b/src/node_http2.cc index 8cb1158b559dec..38686dc7502fdc 100644 --- a/src/node_http2.cc +++ b/src/node_http2.cc @@ -2723,14 +2723,6 @@ void Http2Stream::Destroy(const FunctionCallbackInfo& args) { stream->Destroy(); } -// Prompt the Http2Stream to begin sending data to the JS land. -void Http2Stream::FlushData(const FunctionCallbackInfo& args) { - Http2Stream* stream; - ASSIGN_OR_RETURN_UNWRAP(&stream, args.Holder()); - stream->ReadStart(); - Debug(stream, "data flushed to js"); -} - // Initiate a Push Promise and create the associated Http2Stream void Http2Stream::PushPromise(const FunctionCallbackInfo& args) { Environment* env = Environment::GetCurrent(args); @@ -3129,7 +3121,6 @@ void Initialize(Local target, stream->SetClassName(FIXED_ONE_BYTE_STRING(env->isolate(), "Http2Stream")); env->SetProtoMethod(stream, "id", Http2Stream::GetID); env->SetProtoMethod(stream, "destroy", Http2Stream::Destroy); - env->SetProtoMethod(stream, "flushData", Http2Stream::FlushData); env->SetProtoMethod(stream, "priority", Http2Stream::Priority); env->SetProtoMethod(stream, "pushPromise", Http2Stream::PushPromise); env->SetProtoMethod(stream, "info", Http2Stream::Info); diff --git a/src/node_http2.h b/src/node_http2.h index 9c032f02d17ac7..792078d1261dd0 100644 --- a/src/node_http2.h +++ b/src/node_http2.h @@ -581,7 +581,6 @@ class Http2Stream : public AsyncWrap, // JavaScript API static void GetID(const FunctionCallbackInfo& args); static void Destroy(const FunctionCallbackInfo& args); - static void FlushData(const FunctionCallbackInfo& args); static void Priority(const FunctionCallbackInfo& args); static void PushPromise(const FunctionCallbackInfo& args); static void RefreshState(const FunctionCallbackInfo& args);