Skip to content

Commit

Permalink
test: improve test-gc-http-client
Browse files Browse the repository at this point in the history
Calling `global.gc()` in multiple places leads to unreliability. Call it
in the interval only.

PR-URL: #23145
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
Trott authored and targos committed Oct 3, 2018
1 parent 4436a3d commit 9b30a63
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion test/sequential/test-gc-http-client.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ function getall() {
function cb(res) {
res.resume();
done += 1;
res.on('end', global.gc);
}

function ongc() {
Expand Down

0 comments on commit 9b30a63

Please sign in to comment.