Skip to content

Commit 9abcead

Browse files
trevnorrisrvagg
authored andcommitted
node: fix leaking Context handle
The call to node::Environment::GetCurrent(Isolate*) makes the call to v8::Isolate::GetCurrentContext(). Doing so creates a new handle that bubbled to the v8::SealHandleScope(). PR-URL: #3945 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: James Snell <jasnell@gmail.com>
1 parent 409f6a9 commit 9abcead

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

src/node.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3163,6 +3163,7 @@ static void EnableDebug(Environment* env) {
31633163

31643164
// Called from the main thread.
31653165
static void DispatchDebugMessagesAsyncCallback(uv_async_t* handle) {
3166+
HandleScope scope(node_isolate);
31663167
if (debugger_running == false) {
31673168
fprintf(stderr, "Starting debugger agent.\n");
31683169

0 commit comments

Comments
 (0)