Commit 9990dc7
src,buffer: remove unused chars_written parameter
This parameter was always being set to `nullptr` by its callers, either
explicitly or implicitly via the default argument. It was also buggy, as
in some cases it wouldn't be written to, potentially leaking stack
memory (see the early returns in `StringBytes::WriteUCS2`). Remove it
entirely.
PR-URL: #44092
Reviewed-By: Feng Yu <F3n67u@outlook.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>1 parent c3d8756 commit 9990dc7
File tree
4 files changed
+15
-42
lines changed- src
- api
4 files changed
+15
-42
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
150 | 150 | | |
151 | 151 | | |
152 | 152 | | |
153 | | - | |
| 153 | + | |
154 | 154 | | |
155 | 155 | | |
156 | 156 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
666 | 666 | | |
667 | 667 | | |
668 | 668 | | |
669 | | - | |
670 | | - | |
671 | | - | |
672 | | - | |
673 | | - | |
674 | | - | |
| 669 | + | |
| 670 | + | |
675 | 671 | | |
676 | 672 | | |
677 | 673 | | |
| |||
730 | 726 | | |
731 | 727 | | |
732 | 728 | | |
733 | | - | |
734 | | - | |
735 | | - | |
736 | | - | |
737 | | - | |
738 | | - | |
| 729 | + | |
| 730 | + | |
739 | 731 | | |
740 | 732 | | |
741 | 733 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
260 | 260 | | |
261 | 261 | | |
262 | 262 | | |
263 | | - | |
264 | | - | |
265 | | - | |
266 | | - | |
267 | | - | |
268 | | - | |
| 263 | + | |
| 264 | + | |
269 | 265 | | |
270 | 266 | | |
271 | 267 | | |
| |||
277 | 273 | | |
278 | 274 | | |
279 | 275 | | |
280 | | - | |
281 | 276 | | |
282 | 277 | | |
283 | 278 | | |
284 | 279 | | |
285 | 280 | | |
286 | 281 | | |
287 | 282 | | |
288 | | - | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
289 | 286 | | |
290 | 287 | | |
291 | 288 | | |
| |||
298 | 295 | | |
299 | 296 | | |
300 | 297 | | |
301 | | - | |
302 | 298 | | |
303 | 299 | | |
304 | 300 | | |
305 | | - | |
306 | 301 | | |
307 | 302 | | |
308 | 303 | | |
309 | 304 | | |
310 | | - | |
311 | | - | |
| 305 | + | |
312 | 306 | | |
313 | 307 | | |
314 | | - | |
315 | | - | |
316 | | - | |
317 | | - | |
318 | 308 | | |
319 | 309 | | |
320 | 310 | | |
| |||
334 | 324 | | |
335 | 325 | | |
336 | 326 | | |
337 | | - | |
338 | 327 | | |
339 | 328 | | |
340 | 329 | | |
341 | 330 | | |
342 | | - | |
| 331 | + | |
343 | 332 | | |
344 | 333 | | |
345 | 334 | | |
346 | | - | |
347 | | - | |
348 | | - | |
349 | | - | |
| 335 | + | |
350 | 336 | | |
351 | 337 | | |
352 | 338 | | |
| |||
368 | 354 | | |
369 | 355 | | |
370 | 356 | | |
371 | | - | |
372 | 357 | | |
373 | 358 | | |
374 | 359 | | |
| |||
379 | 364 | | |
380 | 365 | | |
381 | 366 | | |
382 | | - | |
383 | 367 | | |
384 | 368 | | |
385 | 369 | | |
| |||
390 | 374 | | |
391 | 375 | | |
392 | 376 | | |
393 | | - | |
394 | 377 | | |
395 | 378 | | |
396 | 379 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
78 | | - | |
79 | | - | |
| 78 | + | |
80 | 79 | | |
81 | 80 | | |
82 | 81 | | |
| |||
111 | 110 | | |
112 | 111 | | |
113 | 112 | | |
114 | | - | |
115 | | - | |
| 113 | + | |
116 | 114 | | |
117 | 115 | | |
118 | 116 | | |
| |||
0 commit comments