http: improve performance of shouldUseProxy

Author: Uzlopak

benchmark/http/proxy-should-use-proxy.js

@@ -8,6 +8,7 @@ const bench = common.createBenchmark(main, {
   hostname: [
     '127.0.0.1',
     'localhost',
+    'localhost:123',
     'www.example.com',
     'example.com',
     'myexample.com',
@@ -16,6 +17,8 @@ const bench = common.createBenchmark(main, {
     '',
     '*',
     '126.255.255.1-127.0.0.255',
+    'localhost',
+    'localhost:123',
     '127.0.0.1',
     'example.com',
     '.example.com',

lib/internal/http.js

@@ -176,7 +176,7 @@ class ProxyConfig {
     } else {
       this.#buildBypassMatchFns();
       // Use the bypass match functions to determine if the proxy should be used.
-      this.shouldUseProxy = this.#match.bind(this);
+      this.shouldUseProxy = this.#match;
     }
   }
 
@@ -199,8 +199,7 @@ class ProxyConfig {
           continue;
         }
         this.#bypassMatchFns.push((host) => {
-          const hostLength = host.length;
-          const offset = hostLength - suffixLength;
+          const offset = host.length - suffixLength;
           if (offset < 0) return false; // Host is shorter than the suffix.
           for (let i = 0; i < suffixLength; i++) {
             if (host[offset + i] !== suffix[i]) {
@@ -246,8 +245,8 @@ class ProxyConfig {
     const host = hostname.toLowerCase();
     const hostWithPort = port ? `${host}:${port}` : host;
 
-    for (const bypassMatchFn of this.#bypassMatchFns) {
-      if (bypassMatchFn(host, hostWithPort)) {
+    for (let i = 0; i < this.#bypassMatchFns.length; i++) {
+      if (this.#bypassMatchFns[i](host, hostWithPort)) {
         return false; // If any bypass function matches, do not use the proxy.
       }
     }