Skip to content

Commit 97a92c4

Browse files
srl295targos
authored andcommitted
deps: turn in std::string for ICU
- node and v8 did not call into std::string previously, so that access was shut off. - this fixes compilation for ICU 58.2 (backlevel) but may be expressed in other versions also. Fixes: #19151 PR-URL: #19624 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
1 parent 2c5d53f commit 97a92c4

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

tools/icu/icu-generic.gyp

+1-3
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,7 @@
3535
'UCONFIG_NO_REGULAR_EXPRESSIONS=1',
3636
'U_ENABLE_DYLOAD=0',
3737
'U_STATIC_IMPLEMENTATION=1',
38-
# Don't need std::string in API.
39-
# Also, problematic: <http://bugs.icu-project.org/trac/ticket/11333>
40-
'U_HAVE_STD_STRING=0',
38+
'U_HAVE_STD_STRING=1',
4139
# TODO(srl295): reenable following pending
4240
# https://code.google.com/p/v8/issues/detail?id=3345
4341
# (saves some space)

0 commit comments

Comments
 (0)