From 967a15541b97e6e51c43fecbcb198e2d4f44993a Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Tue, 19 Apr 2016 15:31:29 +0200 Subject: [PATCH] v8: warn in Template::Set() on improper use The next major release will make it a fatal error to use non-primitive values in function templates and object templates. Print a warning that includes the C and JS stack trace to tell people to upgrade their add-ons. The C stack trace is only printed on platforms that support it (the BSDs, OS X and Linux+glibc.) The warning can be disabled with the new `--nowarn_template_set` flag. Refs: https://github.com/nodejs/node/issues/6216 PR-URL: https://github.com/nodejs/node/pull/6277 Reviewed-By: James M Snell --- deps/v8/src/api.cc | 11 +++++++++++ deps/v8/src/flag-definitions.h | 3 +++ 2 files changed, 14 insertions(+) diff --git a/deps/v8/src/api.cc b/deps/v8/src/api.cc index 0247d950a7414b..9b6ae720528404 100644 --- a/deps/v8/src/api.cc +++ b/deps/v8/src/api.cc @@ -939,6 +939,17 @@ void Template::Set(v8::Local name, v8::Local value, i::Isolate* isolate = templ->GetIsolate(); ENTER_V8(isolate); i::HandleScope scope(isolate); + auto value_obj = Utils::OpenHandle(*value); + if (i::FLAG_warn_template_set && + value_obj->IsJSReceiver() && + !value_obj->IsTemplateInfo()) { + base::OS::PrintError( + "(node) v8::%sTemplate::Set() with non-primitive values is deprecated\n" + "(node) and will stop working in the next major release.\n", + templ->IsFunctionTemplateInfo() ? "Function" : "Object"); + isolate->PrintStack(stderr, i::Isolate::kPrintStackConcise); + base::DumpBacktrace(); + } // TODO(dcarney): split api to allow values of v8::Value or v8::TemplateInfo. i::ApiNatives::AddDataProperty(isolate, templ, Utils::OpenHandle(*name), Utils::OpenHandle(*value), diff --git a/deps/v8/src/flag-definitions.h b/deps/v8/src/flag-definitions.h index ac430ab503b635..1eb9dd51110b46 100644 --- a/deps/v8/src/flag-definitions.h +++ b/deps/v8/src/flag-definitions.h @@ -172,6 +172,9 @@ struct MaybeBoolFlag { // #define FLAG FLAG_FULL +DEFINE_BOOL(warn_template_set, true, + "warn on deprecated v8::Template::Set() use") + DEFINE_BOOL(experimental_extras, false, "enable code compiled in via v8_experimental_extra_library_files")