Skip to content

Commit 958f5ed

Browse files
lpincaMylesBorins
authored andcommitted
net: remove redundant code from _writeGeneric()
The encoding is already handled by `Writable.prototype.write()`. PR-URL: #18429 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent ae8f5db commit 958f5ed

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

lib/net.js

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -758,13 +758,7 @@ Socket.prototype._writeGeneric = function(writev, data, encoding, cb) {
758758
// Retain chunks
759759
if (err === 0) req._chunks = chunks;
760760
} else {
761-
var enc;
762-
if (data instanceof Buffer) {
763-
enc = 'buffer';
764-
} else {
765-
enc = encoding;
766-
}
767-
err = createWriteReq(req, this._handle, data, enc);
761+
err = createWriteReq(req, this._handle, data, encoding);
768762
}
769763

770764
if (err)

0 commit comments

Comments
 (0)