Skip to content

Commit 9580be9

Browse files
authored
Apply suggestions from code review
1 parent 4c346fa commit 9580be9

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

src/util.cc

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -736,9 +736,8 @@ Local<String> UnionBytes::ToStringChecked(Isolate* isolate) const {
736736
}
737737

738738
RAIIIsolateWithoutEntering::RAIIIsolateWithoutEntering(const SnapshotData* data)
739-
: allocator_{ArrayBuffer::Allocator::NewDefaultAllocator()},
740-
isolate_group_(GetOrCreateIsolateGroup()) {
741-
isolate_ = Isolate::Allocate(isolate_group_);
739+
: allocator_{ArrayBuffer::Allocator::NewDefaultAllocator()} {
740+
isolate_ = Isolate::Allocate();
742741
CHECK_NOT_NULL(isolate_);
743742
per_process::v8_platform.Platform()->RegisterIsolate(isolate_,
744743
uv_default_loop());

src/util.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -990,7 +990,6 @@ class RAIIIsolateWithoutEntering {
990990

991991
private:
992992
std::unique_ptr<v8::ArrayBuffer::Allocator> allocator_;
993-
v8::IsolateGroup isolate_group_;
994993
v8::Isolate* isolate_;
995994
};
996995

0 commit comments

Comments
 (0)